git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: check-attr doesn't respect recursive definitions

From
JLJan Larres <jan@majutsushi.net>
Date
Apr 3, 2013, 10:05 UTC
Message-ID
<slrnklnvo6.jdl.jan@majutsushi.net>
In-Reply-To
<20130402191641.GB17784@sigill.intra.peff.net>
Thanks for the clarifications. Just a quick comment about the summary:
Jeff King <peff@peff.net> wrote:
Show 18 quoted lines
> Yeah, I had the same thought. So you would have to either:
>
>   1. Hook the feature into git-archive, which knows about how it
>      recurses, and can report the correct set of paths.
>
> or
>
>   2. Tell check-attr (or some post-processor) to apply the attribute to
>      elements below the path (or possibly to prune out such paths). This
>      is not the same as recursive application, because you cannot negate
>      it (i.e., you actually find out the final attrs for both "foo" and
>      "foo/bar", and then say "the attr for 'foo' overrides the attr for
>      'foo/bar'".
>
> I posted a patch for (1), but it felt not-very-general. But (2) also
> feels gross and not very general. Even though it could in theory be used
> for things besides git-archive, it is really just applying git-archive's
> pruning rule, which other programs likely don't care about.

I actually think the first approach is not such a bad idea, it would make "archive" more of a general-purpose archiving tool/helper for the repository rather than just something for the special cases of tars and zips. But I guess that's somewhat subjective.

Cheers, Jan

Previous: Jeff KingNext: Duy Nguyen
Message 11 of 13 in “check-attr doesn't respect recursive definitions”
  1. Jan LarresMar 30, 2013
  2. Jeff KingApr 2, 2013
  3. Jeff KingApr 2, 2013
  4. Junio C HamanoApr 2, 2013
  5. Jeff KingApr 2, 2013
  6. Junio C HamanoApr 2, 2013
  7. Jeff KingApr 2, 2013
  8. Jeff KingApr 2, 2013
  9. Junio C HamanoApr 2, 2013
  10. Jeff KingApr 2, 2013
  11. Jan LarresApr 3, 2013
  12. Duy NguyenApr 5, 2013
  13. Jan LarresApr 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.