Re: [PATCH] checkout: squelch "'mode' may be used uninitialized in this function" warning
Any update on this patch? Is it going to maint?
On 2012-04-30, dsp@php.net <dsp@php.net> wrote:
Show 24 quoted lines
> From: David Soria Parra <dsp@php.net>
>
> Use a 'fake' initialization for the 'mode' variable to work around a
> GCC warning as in 5a7a367. The necessary condition to initialize 'mode'
> will always be true but cannot be checked by the compiler.
>
> Signed-off-by: David Soria Parra <dsp@php.net>
> ---
> builtin/checkout.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/builtin/checkout.c b/builtin/checkout.c
> index 84d3eb3..6b8bf31 100644
> --- a/builtin/checkout.c
> +++ b/builtin/checkout.c
> @@ -157,7 +157,7 @@ static int checkout_merged(int pos, struct checkout *state)
> unsigned char sha1[20];
> mmbuffer_t result_buf;
> unsigned char threeway[3][20];
> - unsigned mode;
> + unsigned mode = mode;
>
> memset(threeway, 0, sizeof(threeway));
> while (pos < active_nr) {David Soria Parra <dsp@php.net>