Re: [PATCH] checkout: squelch "'mode' may be used uninitialized in this function" warning

From: Jeff King <peff@peff.net>
Date: May 8, 2012, 20:26 UTC
Message-ID: <20120508202649.GA15502@sigill.intra.peff.net>
In-Reply-To: <slrnjq4p8c.i00.dsp@experimentalworks.net>

On Thu, May 03, 2012 at 10:59:24AM +0000, David Soria Parra wrote:

> Any update on this patch? Is it going to maint?

I doubt it:

Show 10 quoted lines

> > diff --git a/builtin/checkout.c b/builtin/checkout.c
> > index 84d3eb3..6b8bf31 100644
> > --- a/builtin/checkout.c
> > +++ b/builtin/checkout.c
> > @@ -157,7 +157,7 @@ static int checkout_merged(int pos, struct checkout *state)
> >  	unsigned char sha1[20];
> >  	mmbuffer_t result_buf;
> >  	unsigned char threeway[3][20];
> > -	unsigned mode;
> > +	unsigned mode = mode;

What is this based on? This has been fixed since 335c6e4 (checkout_merged(): squelch false warning from some gcc, 2011-12-15), which was in v1.7.8.2.

-Peff