git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/9] http-fetch fixes

From
MWMark Wooding <mdw@distorted.org.uk>
Date
Feb 1, 2006, 15:47 UTC
Message-ID
<slrndu1m14.2i8.mdw@metalzone.distorted.org.uk>
In-Reply-To
<20060201153052.GA16461@informatik.uni-freiburg.de>
Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de> wrote:
>> The series applies to commit 1506fc34f7585880aeeb12b5fdfe2de4800f9df5.
> after reverting c8568e139ed2149fbfb7ef9a8d819d5b6b7c554f it applies to
> 8233340ce6eb700eb2cd9c0fef4d1705997c499b (=current master), too.

Good-oh. (I did pull the latest tip, and then panicked because Nick's change had already made it out.)

> With these patches applied, I get now a Segfault, while cloning
> u-boot.
Oh. :-(  
> Actually now I cannot reproduce it anymore.  I added some debugging code
> s.t. I can give more details if it reoccurs.
Please do.  I've just tried, and I can't reproduce the problem either.

The watch-slots patch seems to uncover all manner of brokenness in http-fetch.c -- or I've violated some unwritten assumptions of a very deep nature, which is always possible.

Maybe the right thing to do is to go with Nick's separate-status- structures patch as an actual mainline fix, with my patches for http-fetch.c's other bugs as a belt-and-braces.

-- [mdw]
Previous: Uwe ZeisbergerNext: Junio C Hamano
Message 16 of 19 in “http-fetch fixes”
  1. 0/9 http-fetch fixesMark Wooding, Feb 1, 2006
  2. 1/9 http-fetch: Mark slots as `watched' to stop them being reused.Mark Wooding, Feb 1, 2006
  3. 2/9 http-fetch: Fix object list corruption in fill_active_slots().Mark Wooding, Feb 1, 2006
  4. 3/9 http-fetch: Abort requests for objects which arrived in packsMark Wooding, Feb 1, 2006
  5. Nick HengeveldFeb 1, 2006
  6. Mark WoodingFeb 1, 2006
  7. Nick HengeveldFeb 6, 2006
  8. 4/9 http-fetch: Actually watch the file descriptors of interest.Mark Wooding, Feb 1, 2006
  9. Nick HengeveldFeb 1, 2006
  10. 5/9 http-fetch: Fix message reporting rename of object file.Mark Wooding, Feb 1, 2006
  11. 6/9 http: Turn on verbose Curl messages if GIT_CURL_VERBOSE set in environmentMark Wooding, Feb 1, 2006
  12. 7/9 http-fetch: Tidy control flow in process_alternate_responseMark Wooding, Feb 1, 2006
  13. 8/9 http: Paranoid sanity checking for active slots.Mark Wooding, Feb 1, 2006
  14. 9/9 http-fetch: Paranoid sanity checking for the object queue.Mark Wooding, Feb 1, 2006
  15. Uwe ZeisbergerFeb 1, 2006
  16. Mark WoodingFeb 1, 2006
  17. Junio C HamanoFeb 2, 2006
  18. Mark WoodingFeb 3, 2006
  19. Junio C HamanoFeb 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.