git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/9] http-fetch: Abort requests for objects which arrived in packs

From
NHNick Hengeveld <nickh@reactrix.com>
Date
Feb 6, 2006, 23:11 UTC
Message-ID
<20060206231124.GJ3873@reactrix.com>
In-Reply-To
<slrndu1rk9.2i8.mdw@metalzone.distorted.org.uk>
On Wed, Feb 01, 2006 at 05:23:21PM +0000, Mark Wooding wrote:
Show 5 quoted lines
> I'm by no means a Curl expert.  But I scoured the docs for another way
> of interrupting the current fetch and I couldn't find anything.  It
> really didn't seem like a good idea to leave the handle as it was,
> having (possibly) half-fetched a thing we weren't actually interested in
> -- that way lies confusion.

My impression from the curl documentation was that removing the curl handle from the multi session was enough, but the documentation doesn't describe what happens to such a request.

Show 5 quoted lines
> Besides, in practice, what's happened is that the object we asked for is
> in a pack which we've just collected.  Unless the upstream repository
> hasn't been git-prune-packed, our fetch is going to fail with a 404
> anyway, at which point Curl /will/ close the connection and make another
> one next time.  So, in real life, it makes no difference.

Good point, and it does seem safer to fully clean up the connection rather than leave it in a questionable state.

-- 
For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.
Previous: Mark WoodingNext: Mark Wooding
Message 7 of 19 in “http-fetch fixes”
  1. 0/9 http-fetch fixesMark Wooding, Feb 1, 2006
  2. 1/9 http-fetch: Mark slots as `watched' to stop them being reused.Mark Wooding, Feb 1, 2006
  3. 2/9 http-fetch: Fix object list corruption in fill_active_slots().Mark Wooding, Feb 1, 2006
  4. 3/9 http-fetch: Abort requests for objects which arrived in packsMark Wooding, Feb 1, 2006
  5. Nick HengeveldFeb 1, 2006
  6. Mark WoodingFeb 1, 2006
  7. Nick HengeveldFeb 6, 2006
  8. 4/9 http-fetch: Actually watch the file descriptors of interest.Mark Wooding, Feb 1, 2006
  9. Nick HengeveldFeb 1, 2006
  10. 5/9 http-fetch: Fix message reporting rename of object file.Mark Wooding, Feb 1, 2006
  11. 6/9 http: Turn on verbose Curl messages if GIT_CURL_VERBOSE set in environmentMark Wooding, Feb 1, 2006
  12. 7/9 http-fetch: Tidy control flow in process_alternate_responseMark Wooding, Feb 1, 2006
  13. 8/9 http: Paranoid sanity checking for active slots.Mark Wooding, Feb 1, 2006
  14. 9/9 http-fetch: Paranoid sanity checking for the object queue.Mark Wooding, Feb 1, 2006
  15. Uwe ZeisbergerFeb 1, 2006
  16. Mark WoodingFeb 1, 2006
  17. Junio C HamanoFeb 2, 2006
  18. Mark WoodingFeb 3, 2006
  19. Junio C HamanoFeb 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.