Re: [PATCH] Fix sloppy Getopt::Long.
- From
Robin H. Johnson <robbat2@gentoo.org>
- Date
- May 8, 2009, 18:28 UTC
- Message-ID
- <robbat2.20090508T182516.673117391Z@orbis-terrarum.net>
- In-Reply-To
- <7v63gew3dp.fsf@alter.siamese.dyndns.org>
On Wed, May 06, 2009 at 10:24:50AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> >> + { '' => \$_stdin, 'stdin' => \$_stdin,
> >> + %cmt_opts, %fc_opts, } ],
> > I confirm that it does correctly set the $_stdin variable (tested
> > briefly).
> Wait a minute. Do you mean we would also need the above "explicit empty
> argument sets $_stdin"? Wasn't it your earlier analysis/claim that the
> caller already takes care of a lone "-"?I'd originally considered a single '-' as an argument not an option, meaning stdin, not being processed within the getopt framework, but instead being handled later.
> Or do you mean "yes it would also work but it is not necessary"?
Using Eric's change makes it explicit what is expected: Passing '--stdin' is the same as passing '-'.
-- Robin Hugh Johnson Gentoo Linux Developer & Infra Guy E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85