git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix sloppy Getopt::Long.

From
Robin H. Johnson <robbat2@gentoo.org>
Date
May 5, 2009, 18:16 UTC
Message-ID
<1241547374-6737-1-git-send-email-robbat2@gentoo.org>

Getopt-Long v2.38 is much stricter about sloppy getopt usage. The trailing pipe causes git-svn testcases to fail for all of the --stdin argument calls.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
===
Should be applied to both the stable 1.6.2.x tree and the new 1.6.3
tree.
---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index c5965c9..ef1d30d 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -147,7 +147,7 @@ my %cmd = (
 	           'dry-run|n' => \$_dry_run } ],
 	'set-tree' => [ \&cmd_set_tree,
 	                "Set an SVN repository to a git tree-ish",
-			{ 'stdin|' => \$_stdin, %cmt_opts, %fc_opts, } ],
+			{ 'stdin' => \$_stdin, %cmt_opts, %fc_opts, } ],
 	'create-ignore' => [ \&cmd_create_ignore,
 			     'Create a .gitignore per svn:ignore',
 			     { 'revision|r=i' => \$_revision
-- 
1.6.2.3
Next: Junio C Hamano
Message 1 of 6 in “Fix sloppy Getopt::Long.”
  1. Fix sloppy Getopt::Long.Robin H. Johnson, May 5, 2009
  2. Junio C HamanoMay 5, 2009
  3. Robin H. JohnsonMay 5, 2009
  4. Robin H. JohnsonMay 6, 2009
  5. Junio C HamanoMay 6, 2009
  6. Robin H. JohnsonMay 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.