regression AGAIN in output of git-pull --rebase --recurse-submodules=yes --quiet
- From
Robin H. Johnson <robbat2@gentoo.org>
- Date
- Apr 10, 2019, 06:41 UTC
- Message-ID
- <robbat2-20190410T062730-540884809Z@orbis-terrarum.net>
- In-Reply-To
- <robbat2-20180120T054223-685328376Z@orbis-terrarum.net>
A year ago, I raised <robbat2-20190410T062730-540884809Z@orbis-terrarum.net> as an issue, which lead to commit commit a56771a668dd4963675914bc5da0e1e015952dae.
The exact same workload somewhere between 2.18.0 and 2.19.0 has caused the message to come back. I noticed it first in a 2.18.0->2.21.0 upgrade, and did a partial bisect based on tags to trace it to 2.19.0.
=== $ git submodule foreach --quiet git pull origin master --quiet >/dev/null From git://anongit.gentoo.org/data/gentoo-news * branch master -> FETCH_HEAD From git://anongit.gentoo.org/data/glep * branch master -> FETCH_HEAD ===
I suspect it was a result of: ea27893a65cc41cad2710466aa6a58866ff22f1e Merge branch 'pc/submodule-helper-foreach'
But I haven't done a full bisect to prove it yet.
On Sat, Jan 20, 2018 at 05:57:29AM +0000, Robin H. Johnson wrote:
Show 33 quoted lines
> Somewhere between 2.13.6 & 2.14.1 there's an output regression. I > haven't done a bisect to trace it down further yet. > > Specifically, --rebase --recurse-submodules=yes seems to cause --quiet > to not be effective anymore. > > Full commandline: > $ git pull --rebase --recurse-submodules --quiet > > In 2.13.6, there is no output, it's quiet as expect. > > In 2.14.1, you get: > HEAD is up to date. > Submodule path '_data/news': rebased into 'a50b763c338161b4621d23e9fa5cd6e11455d6ca' > HEAD is up to date. > Submodule path 'glep': rebased into 'e1f100ec3ba44ab1672d61cabf4690b355e46158' > > Steps to reproduction: > 1. git clone --recurse-submodules \ > https://anongit.gentoo.org/git/sites/www.git > 2. cd www > 3. git submodule foreach --quiet git pull --quiet origin master > 4. git pull --rebase --recurse-submodules=yes --quiet > > Repeat step 4 for repeated bug output. > If you drop the --rebase, then you need to re-run step 3 first. > > -- > Robin Hugh Johnson > Gentoo Linux: Dev, Infra Lead, Foundation Treasurer > E-Mail : robbat2@gentoo.org > GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 > GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136
-- Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation Treasurer E-Mail : robbat2@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136