git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/pull: respect verbosity settings in submodules

From
Stefan Beller <sbeller@google.com>
Date
Jan 25, 2018, 19:08 UTC
Message-ID
<20180125190817.145041-1-sbeller@google.com>
In-Reply-To
<robbat2-20180120T054223-685328376Z@orbis-terrarum.net>

In a6d7eb2c7a (pull: optionally rebase submodules (remote submodule changes only), 2017-06-23), we taught Git how to rebase submodules in a pull. However we missed to pass on the verbosity settings.

Reported-by: Robin H. Johnson <robbat2@gentoo.org>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 builtin/pull.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/builtin/pull.c b/builtin/pull.c
index 511dbbe0f6..1876271af9 100644
--- a/builtin/pull.c
+++ b/builtin/pull.c
@@ -574,6 +574,7 @@ static int rebase_submodules(void)
 	cp.no_stdin = 1;
 	argv_array_pushl(&cp.args, "submodule", "update",
 				   "--recursive", "--rebase", NULL);
+	argv_push_verbosity(&cp.args);
 
 	return run_command(&cp);
 }
@@ -586,6 +587,7 @@ static int update_submodules(void)
 	cp.no_stdin = 1;
 	argv_array_pushl(&cp.args, "submodule", "update",
 				   "--recursive", "--checkout", NULL);
+	argv_push_verbosity(&cp.args);
 
 	return run_command(&cp);
 }
-- 
2.16.0.rc1.238.g530d649a79-goog
Previous: Robin H. JohnsonNext: Junio C Hamano
Message 2 of 12 in “regression in output of git-pull --rebase --recurse-submodules=yes --quiet”
  1. Robin H. JohnsonJan 20, 2018
  2. builtin/pull: respect verbosity settings in submodulesStefan Beller, Jan 25, 2018
  3. Junio C HamanoJan 25, 2018
  4. regression AGAIN in output of git-pull --rebase --recurse-submodules=yes --quietRobin H. Johnson, Apr 10, 2019
  5. Duy NguyenApr 10, 2019
  6. Robin H. JohnsonApr 12, 2019
  7. Duy NguyenApr 12, 2019
  8. Johannes SchindelinApr 15, 2019
  9. submodule foreach: fix "<command> --quiet" not being respectedNguyễn Thái Ngọc Duy, Apr 12, 2019
  10. Robin H. JohnsonApr 12, 2019
  11. Junio C HamanoApr 15, 2019
  12. Duy NguyenApr 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.