git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Building Git on Tru64

From
Alex Riesen <raa.lkml@gmail.com>
Date
Apr 15, 2010, 19:29 UTC
Message-ID
<r2n81b0412b1004151229g6fe840a1v23a9d06f72e8d36a@mail.gmail.com>
In-Reply-To
<1271358589.19032.1370170305@webmail.messagingengine.com>
On Thu, Apr 15, 2010 at 21:09, Daniel Richard G. <skunk@iskunk.org> wrote:
> * On Tru64, MAP_FAILED is #defined as (-1L), and the compiler chokes if
>  you directly compare a pointer to an integer. So, need to cast
>  MAP_FAILED to (void *), redundant as that may seem.

That one may be better handled at one place (git-compat-util.h?) with something like:

  #ifdef Tru64
  #define MAP_FAILED ((void *)MAP_FAILED)
  #endif

P.S. You may consider reading Documentation/SubmittingPatches. The way you did it is a little unconventional.

Previous: Daniel Richard G.Next: Daniel Richard G.
Message 2 of 7 in “Building Git on Tru64”
  1. Building Git on Tru64Daniel Richard G., Apr 15, 2010
  2. Alex RiesenApr 15, 2010
  3. Daniel Richard G.Apr 15, 2010
  4. Nicolas PitreApr 15, 2010
  5. Daniel Richard G.Apr 15, 2010
  6. Jakub NarebskiApr 15, 2010
  7. Erik Faye-LundApr 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.