From: Alex Riesen Date: Thu, 15 Apr 2010 19:29:11 GMT Subject: Re: [PATCH] Building Git on Tru64 Message-ID: In-Reply-To: <1271358589.19032.1370170305@webmail.messagingengine.com> On Thu, Apr 15, 2010 at 21:09, Daniel Richard G. wrote: > * On Tru64, MAP_FAILED is #defined as (-1L), and the compiler chokes if >  you directly compare a pointer to an integer. So, need to cast >  MAP_FAILED to (void *), redundant as that may seem. That one may be better handled at one place (git-compat-util.h?) with something like: #ifdef Tru64 #define MAP_FAILED ((void *)MAP_FAILED) #endif P.S. You may consider reading Documentation/SubmittingPatches. The way you did it is a little unconventional.