Re: [PATCH] Support diff.autorefreshindex=true in `git-diff --quiet'

From: Karl Chen <quarl@cs.berkeley.edu>
Date: Sep 2, 2008, 17:39 UTC
Message-ID: <quack.20080902T1039.lthabeqmopo_-_@roar.cs.berkeley.edu>
In-Reply-To: <7vy72bnk5x.fsf_-_@gitster.siamese.dyndns.org>

>>>>> On 2008-09-01 23:20 PDT, Junio C Hamano writes:

    Junio> Looking at your patch and thinking about the issue very
    Junio> much tempt me to suggest the attached patch which is at
    Junio> the other extreme of the spectrum.

I think it is the extreme at the same end of the spectrum and I like it. (I was tempted to do this but thought there was a reason those options were ignored by --quiet.) This is good because it makes --quiet do what one thinks it does, and what's documented, with no exceptions (i.e. equivalent to --exit-code > /dev/null).

If anyone actually used the old behavior of ignoring diff.autorefreshindex (as an optimization, because the script ran update-index --refresh outside a loop), there could be a --quick option, or they could use git-diff-files.