Re: [PATCH] Support diff.autorefreshindex=true in `git-diff --quiet'

From: Karl Chen <quarl@cs.berkeley.edu>
Date: Sep 1, 2008, 10:50 UTC
Message-ID: <quack.20080901T0350.lthzlmsgmx6@roar.cs.berkeley.edu>
In-Reply-To: <7vskskw41j.fsf@gitster.siamese.dyndns.org>

>>>>> On 2008-09-01 03:31 PDT, Junio C Hamano writes:

    Junio> Karl Chen <quarl@cs.berkeley.edu> writes:
    >> When diff.autorefreshindex is true, if a file has merely
    >> been 'touched' (mtime changed, but contents unchanged),
    >> then `git-diff --quiet' will now return 0 (indicating no
    >> change) instead of 1, and also silently refresh the index.

    Junio> My knee-jerk reaction is that I do not particularly
    Junio> like this, but I haven't thought things through.  What
    Junio> does --exit-code do with or without the configuration
    Junio> variable?

git diff --exit-code silently refreshes the index and returns 0, as documented and as I expect. So I further expect "git diff --exit-code --quiet" to be have the same semantics as "git diff --exit-code >/dev/null".

What don't you like about this? Isn't this the point of diff.autorefreshindex ?