Re: [RFC PATCH 2/2] Remove now useless email-address parsing code

From: Matthieu Moy <git@matthieu-moy.fr>
Date: Jan 5, 2018, 09:39 UTC
Message-ID: <q7h9wp0wod8y.fsf@orange.lip.ens-lyon.fr>
In-Reply-To: <87po6pcm08.fsf@linaro.org>

Alex Bennée <alex.bennee@linaro.org> writes:

Show 15 quoted lines

> Matthieu Moy <git@matthieu-moy.fr> writes:
>
>> We now use Mail::Address unconditionaly, hence parse_mailboxes is now
>> dead code. Remove it and its tests.
>>
>> Signed-off-by: Matthieu Moy <git@matthieu-moy.fr>
>> ---
>>  perl/Git.pm          | 71 ----------------------------------------------------
>>  t/t9000-addresses.sh | 27 --------------------
>>  t/t9000/test.pl      | 67 -------------------------------------------------
>>  3 files changed, 165 deletions(-)
>>  delete mode 100755 t/t9000-addresses.sh
>>  delete mode 100755 t/t9000/test.pl
>
> Should we add the tests for t9001-send-email.sh to guard against regressions?

Tests in t9001 were only useful with our parse_mailboxes (they were just comparing parse_mailboxes and Mail::Address), so there's no point keeping them after we delete parse_mailboxes.

Your added tests from https://public-inbox.org/git/20171116154814.23785-1-alex.bennee@linaro.org would make sense OTOH. Not breaking Linux's flow is a nice thing to do ... Patch doing this follows (I'll resend the whole series with Eric's nit later).

-- 
Matthieu Moy
https://matthieu-moy.fr/