git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: add test for Linux's get_maintainer.pl

From
Alex Bennée <alex.bennee@linaro.org>
Date
Jan 5, 2018, 11:15 UTC
Message-ID
<87o9m8d09u.fsf@linaro.org>
In-Reply-To
<1515147109-8077-1-git-send-email-git@matthieu-moy.fr>
Matthieu Moy <git@matthieu-moy.fr> writes:
Show 46 quoted lines
> From: Alex Bennée <alex.bennee@linaro.org>
>
> We had a regression that broke Linux's get_maintainer.pl. Using
> Mail::Address to parse email addresses fixed it, but let's protect
> against future regressions.
>
> Patch-edited-by: Matthieu Moy <git@matthieu-moy.fr>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Matthieu Moy <git@matthieu-moy.fr>
> ---
>  t/t9001-send-email.sh | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 4d261c2..f126177 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -172,6 +172,28 @@ test_expect_success $PREREQ 'cc trailer with various syntax' '
>  	test_cmp expected-cc commandline1
>  '
>
> +test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' "
> +	cat >expected-cc-script.sh <<-EOF &&
> +	#!/bin/sh
> +	echo 'One Person <one@example.com> (supporter:THIS (FOO/bar))'
> +	echo 'Two Person <two@example.com> (maintainer:THIS THING)'
> +	echo 'Third List <three@example.com> (moderated list:THIS THING (FOO/bar))'
> +	echo '<four@example.com> (moderated list:FOR THING)'
> +	echo 'five@example.com (open list:FOR THING (FOO/bar))'
> +	echo 'six@example.com (open list)'
> +	EOF
> +	chmod +x expected-cc-script.sh
> +"
> +
> +test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' '
> +	test_commit cc-trailer-getmaint &&
> +	clean_fake_sendmail &&
> +	git send-email -1 --to=recipient@example.com \
> +		--cc-cmd="./expected-cc-script.sh" \
> +		--smtp-server="$(pwd)/fake.sendmail" &&
> +	test_cmp expected-cc commandline1
> +'
> +
>  test_expect_success $PREREQ 'setup expect' "
>  cat >expected-show-all-headers <<\EOF
>  0001-Second.patch
I think you need to apply Eric's suggestions from:
  From: Eric Sunshine <sunshine@sunshineco.com>
  Date: Sat, 18 Nov 2017 21:54:46 -0500
  Message-ID: <CAPig+cSh0tVVkh0xF9FwCfM4gngAWMSN_FXd2zhzHcy2trYXfw@mail.gmail.com>

-- Alex Bennée

Previous: Matthieu MoyNext: Matthieu Moy
Message 6 of 22 in “add a local copy of Mail::Address from CPAN”
  1. 1/2 add a local copy of Mail::Address from CPANMatthieu Moy, Jan 4, 2018
  2. 2/2 Remove now useless email-address parsing codeMatthieu Moy, Jan 4, 2018
  3. Alex BennéeJan 4, 2018
  4. Matthieu MoyJan 5, 2018
  5. send-email: add test for Linux's get_maintainer.plMatthieu Moy, Jan 5, 2018
  6. Alex BennéeJan 5, 2018
  7. Matthieu MoyJan 5, 2018
  8. Junio C HamanoJan 5, 2018
  9. Eric SunshineJan 4, 2018
  10. Ævar Arnfjörð BjarmasonJan 5, 2018
  11. 1/3 send-email: add and use a local copy of Mail::AddressMatthieu Moy, Jan 5, 2018
  12. 2/3 Remove now useless email-address parsing codeMatthieu Moy, Jan 5, 2018
  13. 3/3 send-email: add test for Linux's get_maintainer.plMatthieu Moy, Jan 5, 2018
  14. Eric SunshineJan 5, 2018
  15. Matthieu MoyJan 8, 2018
  16. 1/3 send-email: add and use a local copy of Mail::AddressMatthieu Moy, Jan 8, 2018
  17. 3/3 send-email: add test for Linux's get_maintainer.plMatthieu Moy, Jan 8, 2018
  18. Junio C HamanoJan 8, 2018
  19. 2/3 Remove now useless email-address parsing codeMatthieu Moy, Jan 8, 2018
  20. Alex BennéeJan 8, 2018
  21. Alex BennéeJan 8, 2018
  22. Ævar Arnfjörð BjarmasonFeb 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.