Re: [PATCH v2] remote-mediawiki: limit filenames to legal
- From
Matthieu Moy <matthieu.moy@univ-lyon1.fr>
- Date
- Oct 30, 2017, 10:34 UTC
- Message-ID
- <q7h9fua0zzz0.fsf@orange.lip.ens-lyon.fr>
- In-Reply-To
- <20171029181034.27707-1-anarcat@debian.org>
Antoine Beaupré <anarcat@debian.org> writes:
Show 6 quoted lines
> @@ -52,7 +53,7 @@ sub smudge_filename {
> $filename =~ s/ /_/g;
> # Decode forbidden characters encoded in clean_filename
> $filename =~ s/_%_([0-9a-fA-F][0-9a-fA-F])/sprintf('%c', hex($1))/ge;
> - return $filename;
> + return substr($filename, 0, NAME_MAX-3);There's a request to allow a configurable extension (.mediawiki would help importing in some wikis, see https://github.com/Git-Mediawiki/Git-Mediawiki/issues/42). You should at least make this stg like length(".mw") so that the next search&replace for ".mw" finds this.
Also, note that your solution works for using Git-Mediawiki in a read-only way, but if you start modifying and pushing such files, you'll get into trouble. It probably makes sense to issue a warnign in such case.
Regards,
-- Matthieu Moy https://matthieu-moy.fr/