Re: [PATCH v2] remote-mediawiki: limit filenames to legal

From: Antoine Beaupré <anarcat@debian.org>
Date: Oct 30, 2017, 12:31 UTC
Message-ID: <87h8ug7r75.fsf@curie.anarc.at>
In-Reply-To: <q7h9fua0zzz0.fsf@orange.lip.ens-lyon.fr>

On 2017-10-30 11:34:11, Matthieu Moy wrote:

Show 14 quoted lines

> Antoine Beaupré <anarcat@debian.org> writes:
>
>> @@ -52,7 +53,7 @@ sub smudge_filename {
>>  	$filename =~ s/ /_/g;
>>  	# Decode forbidden characters encoded in clean_filename
>>  	$filename =~ s/_%_([0-9a-fA-F][0-9a-fA-F])/sprintf('%c', hex($1))/ge;
>> -	return $filename;
>> +	return substr($filename, 0, NAME_MAX-3);
>
> There's a request to allow a configurable extension (.mediawiki would
> help importing in some wikis, see
> https://github.com/Git-Mediawiki/Git-Mediawiki/issues/42). You should at
> least make this stg like length(".mw") so that the next search&replace
> for ".mw" finds this.

I believe I did that in v3.

> Also, note that your solution works for using Git-Mediawiki in a
> read-only way, but if you start modifying and pushing such files, you'll
> get into trouble. It probably makes sense to issue a warnign in such
> case.

True. I didn't consider that, but then again the patch is not a regression: you couldn't have pushed those repos in the first place anyways...

A.

-- 
The history of any one part of the earth, like the life of a soldier,
consists of long periods of boredom and short periods of terror.
                       - British geologist Derek V. Ager