git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] check-whitespace: two fixes

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 14, 2021, 22:09 UTC
Message-ID
<pull.995.git.1626300577.gitgitgadget@gmail.com>

I recently ran into a situation where a merge commit (which admittedly are undesirable in git/git and gitgitgadget/git Pull Requests, but are sometimes totally appropriate in the context of other forks such as git-for-windows/git) misled the logic in the check-whitespace workflow to look at upstream commits (and missing some patches that it should have looked at).

At the same time, I also realized that the feature where this workflow adds a PR comment in an attempt to be more helpful requires a read/write token (which weakens the overall security, I'd much rather stay with the read-only token configured e.g. in gitgitgadget/git and in git-for-windows/git).

This patch series addresses both issues.
Johannes Schindelin (2):
  ci(check-whitespace): stop requiring a read/write token
  ci(check-whitespace): restrict to the intended commits
 .github/workflows/check-whitespace.yml | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)
base-commit: ebf3c04b262aa27fbb97f8a0156c2347fecafafb
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-995%2Fdscho%2Ffix-check-whitespace-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-995/dscho/fix-check-whitespace-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/995
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 8 in “check-whitespace: two fixes”
  1. 0/2 check-whitespace: two fixesJohannes Schindelin via GitGitGadget, Jul 14, 2021
  2. 1/2 ci(check-whitespace): stop requiring a read/write tokenJohannes Schindelin via GitGitGadget, Jul 14, 2021
  3. Junio C HamanoJul 14, 2021
  4. 2/2 ci(check-whitespace): restrict to the intended commitsJohannes Schindelin via GitGitGadget, Jul 14, 2021
  5. Junio C HamanoJul 14, 2021
  6. Taylor BlauJul 14, 2021
  7. Johannes SchindelinJul 15, 2021
  8. Johannes SchindelinJul 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.