Re: [PATCH 2/2] ci(check-whitespace): restrict to the intended commits

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 15, 2021, 12:59 UTC
Message-ID: <nycvar.QRO.7.76.6.2107151458320.59@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqwnpsttx0.fsf@gitster.g>

Hi Junio,

On Wed, 14 Jul 2021, Junio C Hamano wrote:

Show 16 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > Unfortunately, this means that we no longer can rely on a shallow clone:
> > There is no way of knowing just how many commits the upstream branch
> > advanced after the commit from which the PR branch branched off. So
> > let's just go with a full clone instead, and be safe rather than sorry
> > (if we have "too shallow" a situation, a commit range `@{u}..` may very
> > well include a shallow commit itself, and the output of `git show
> > --check <shallow>` is _not_ pretty).
>
> Makes sense.
>
> As long as you have pull-request base, I suspect that you could
> shallow clone the base and incrementally fetch the rest to update,
> perhaps?

Fetching into shallow clones is very expensive on the server. I want to avoid that whenever possible.

> But I do not know if it is worth doing so for a small project like ours.

And then there's that.

Ciao, Dscho