git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] sequencer: remove duplicate rollback_lock_file() call

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 21, 2020, 13:24 UTC
Message-ID
<pull.894.git.git.1603286675709.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>

Commit 2b6ad0f4bc ("rebase --rebase-merges: add support for octopus merges", 2017-12-21) introduced a case where rollback_lock_file() was unconditionally called twice in a row with no intervening commands. Remove the duplicate.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
    sequencer: remove duplicate rollback_lock_file() call
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-894%2Fnewren%2Fremove-duplicate-sequencer-code-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-894/newren/remove-duplicate-sequencer-code-v1
Pull-Request: https://github.com/git/git/pull/894
 sequencer.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/sequencer.c b/sequencer.c
index 00acb12496..baff51035e 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -3689,7 +3689,6 @@ static int do_merge(struct repository *r,
 				NULL, 0);
 		rollback_lock_file(&lock);
 
-		rollback_lock_file(&lock);
 		ret = run_command(&cmd);
 
 		/* force re-reading of the cache */

base-commit: 69986e19ffcfb9af674ae5180689ab7bbf92ed28
-- 
gitgitgadget
Next: Taylor Blau
Message 1 of 4 in “sequencer: remove duplicate rollback_lock_file() call”
  1. sequencer: remove duplicate rollback_lock_file() callElijah Newren via GitGitGadget, Oct 21, 2020
  2. Taylor BlauOct 21, 2020
  3. Junio C HamanoOct 21, 2020
  4. Johannes SchindelinOct 22, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.