git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: remove duplicate rollback_lock_file() call

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 21, 2020, 17:17 UTC
Message-ID
<20201021171727.GA1237181@nand.local>
In-Reply-To
<pull.894.git.git.1603286675709.gitgitgadget@gmail.com>
Hi Elijah,
On Wed, Oct 21, 2020 at 01:24:35PM +0000, Elijah Newren via GitGitGadget wrote:
Show 9 quoted lines
> diff --git a/sequencer.c b/sequencer.c
> index 00acb12496..baff51035e 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -3689,7 +3689,6 @@ static int do_merge(struct repository *r,
>  				NULL, 0);
>  		rollback_lock_file(&lock);
>
> -		rollback_lock_file(&lock);
Looks obviously good to me, thanks.
  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

Previous: Elijah Newren via GitGitGadgetNext: Junio C Hamano
Message 2 of 4 in “sequencer: remove duplicate rollback_lock_file() call”
  1. sequencer: remove duplicate rollback_lock_file() callElijah Newren via GitGitGadget, Oct 21, 2020
  2. Taylor BlauOct 21, 2020
  3. Junio C HamanoOct 21, 2020
  4. Johannes SchindelinOct 22, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.