git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 7, 2020, 08:17 UTC
Message-ID
<pull.744.git.1602058669919.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

It is the custom to follow minor updates of GitHub Actions automatically, by using the suffix `@v1`. Actions' maintainers will then update that `v1` ref to point to the newest.

However, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure GitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0` suffix.

In this instance, that is a problem: should `setup-msbuild` release a new version that intends to fix a critical bug, we won't know it, and we won't use it.

Such a scenario is not theoretical. It is happening right now: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands

Let's simplify our setup, allowing us to benefit from automatically using the newest v1.x.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    GitHub workflow: automatically follow minor updates of setup-msbuild
    
    This patch was based on dd/ci-swap-azure-pipelines-with-github-actions,
    but due to changes outside of Git, that GitHub workflow does not even
    begin to work anymore. Therefore, the patch is now actually based on 
    master.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-744%2Fdscho%2Fsimplify-setup-msbuild-upgrades-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-744/dscho/simplify-setup-msbuild-upgrades-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/744
 .github/workflows/main.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index fcfd138ff1..14ff94dcbe 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -154,7 +154,7 @@ jobs:
         Expand-Archive compat.zip -DestinationPath . -Force
         Remove-Item compat.zip
     - name: add msbuild to PATH
-      uses: microsoft/setup-msbuild@v1.0.0
+      uses: microsoft/setup-msbuild@v1
     - name: copy dlls to root
       shell: powershell
       run: |

base-commit: d98273ba77e1ab9ec755576bc86c716a97bf59d7
-- 
gitgitgadget
Next: Jeff King
Message 1 of 2 in “GitHub workflow: automatically follow minor updates of setup-msbuild”
  1. GitHub workflow: automatically follow minor updates of setup-msbuildJohannes Schindelin via GitGitGadget, Oct 7, 2020
  2. Jeff KingOct 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.