Re: [PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild

From: Jeff King <peff@peff.net>
Date: Oct 7, 2020, 12:49 UTC
Message-ID: <20201007124957.GA123549@coredump.intra.peff.net>
In-Reply-To: <pull.744.git.1602058669919.gitgitgadget@gmail.com>

On Wed, Oct 07, 2020 at 08:17:49AM +0000, Johannes Schindelin via GitGitGadget wrote:

Show 17 quoted lines

> It is the custom to follow minor updates of GitHub Actions
> automatically, by using the suffix `@v1`. Actions' maintainers will then
> update that `v1` ref to point to the newest.
> 
> However, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure
> GitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0`
> suffix.
> 
> In this instance, that is a problem: should `setup-msbuild` release a
> new version that intends to fix a critical bug, we won't know it, and we
> won't use it.
> 
> Such a scenario is not theoretical. It is happening right now:
> https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands
> 
> Let's simplify our setup, allowing us to benefit from automatically
> using the newest v1.x.

Thanks, that explanation makes perfect sense and the patch looks obviously correct.

-Peff