git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] oidset: remove unnecessary include

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 14, 2020, 19:15 UTC
Message-ID
<pull.727.git.git.1584213347500.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>

When commit 8b2f8cbcb1 ("oidset: use khash", 2018-10-04) moved from using oidmap to khash, it replaced the oidmap.h include with both one for hashmap.h and khash.h. Since the hashmap.h header is unnecessary, and the point of the patch was to switch from hashmap (used by oidmap) to khash.h, remove the unneccessary include.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
    oidset: remove unnecessary include
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-727%2Fnewren%2Foidset-cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-727/newren/oidset-cleanup-v1
Pull-Request: https://github.com/git/git/pull/727
 oidset.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/oidset.h b/oidset.h
index 5346563b0bc..d8a106b1275 100644
--- a/oidset.h
+++ b/oidset.h
@@ -1,7 +1,6 @@
 #ifndef OIDSET_H
 #define OIDSET_H
 
-#include "hashmap.h"
 #include "khash.h"
 
 /**

base-commit: 30e9940356dc67959877f4b2417da33ebdefbb79
-- 
gitgitgadget
Next: Jeff King
Message 1 of 2 in “oidset: remove unnecessary include”
  1. oidset: remove unnecessary includeElijah Newren via GitGitGadget, Mar 14, 2020
  2. Jeff KingMar 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.