git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] oidset: remove unnecessary include

From
Jeff King <peff@peff.net>
Date
Mar 16, 2020, 19:28 UTC
Message-ID
<20200316192852.GC1073710@coredump.intra.peff.net>
In-Reply-To
<pull.727.git.git.1584213347500.gitgitgadget@gmail.com>
On Sat, Mar 14, 2020 at 07:15:47PM +0000, Elijah Newren via GitGitGadget wrote:
Show 7 quoted lines
> From: Elijah Newren <newren@gmail.com>
> 
> When commit 8b2f8cbcb1 ("oidset: use khash", 2018-10-04) moved from
> using oidmap to khash, it replaced the oidmap.h include with both one
> for hashmap.h and khash.h.  Since the hashmap.h header is unnecessary,
> and the point of the patch was to switch from hashmap (used by oidmap)
> to khash.h, remove the unneccessary include.

Good catch. I doubt this is causing problems, but it's obviously the right thing to do. I ran "make hdr-check" to confirm that no _other_ headers were subtly relying on this include.

-Peff
Previous: Elijah Newren via GitGitGadget
Message 2 of 2 in “oidset: remove unnecessary include”
  1. oidset: remove unnecessary includeElijah Newren via GitGitGadget, Mar 14, 2020
  2. Jeff KingMar 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.