git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] refs: add missing optimize implementation for debug ref backend

From
XGXinyu Ruan via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 31, 2025, 03:37 UTC
Message-ID
<pull.2090.git.git.1761881859881.gitgitgadget@gmail.com>
From: Xinyu Ruan <r200981113@gmail.com>

The debug ref backend (refs_be_debug) was missing the optimize function pointer, which caused a segmentation fault when running 'GIT_TRACE_REFS=1 git pack-refs --all' command.

Signed-off-by: Xinyu Ruan <r200981113@gmail.com>
---
    refs: add missing optimize implementation for debug ref backend
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2090%2FRuanXinyu%2Fref-debug-optimize-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2090/RuanXinyu/ref-debug-optimize-v1
Pull-Request: https://github.com/git/git/pull/2090
 refs/debug.c | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/refs/debug.c b/refs/debug.c
index 697adbd0dc..8dad7046cd 100644
--- a/refs/debug.c
+++ b/refs/debug.c
@@ -124,6 +124,14 @@ static int debug_pack_refs(struct ref_store *ref_store, struct pack_refs_opts *o
 	return res;
 }
 
+static int debug_optimize(struct ref_store *ref_store, struct pack_refs_opts *opts)
+{
+	struct debug_ref_store *drefs = (struct debug_ref_store *)ref_store;
+	int res = drefs->refs->be->optimize(drefs->refs, opts);
+	trace_printf_key(&trace_refs, "optimize: %d\n", res);
+	return res;
+}
+
 static int debug_rename_ref(struct ref_store *ref_store, const char *oldref,
 			    const char *newref, const char *logmsg)
 {
@@ -444,6 +452,7 @@ struct ref_storage_be refs_be_debug = {
 	.transaction_abort = debug_transaction_abort,
 
 	.pack_refs = debug_pack_refs,
+	.optimize = debug_optimize,
 	.rename_ref = debug_rename_ref,
 	.copy_ref = debug_copy_ref,
 

base-commit: a99f379adf116d53eb11957af5bab5214915f91d
-- 
gitgitgadget
Next: Patrick Steinhardt
Message 1 of 2 in “refs: add missing optimize implementation for debug ref backend”
  1. refs: add missing optimize implementation for debug ref backendXinyu Ruan via GitGitGadget, Oct 31, 2025
  2. Patrick SteinhardtOct 31, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.