git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: add missing optimize implementation for debug ref backend

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 31, 2025, 06:39 UTC
Message-ID
<aQRZizsobXECzvJI@pks.im>
In-Reply-To
<pull.2090.git.git.1761881859881.gitgitgadget@gmail.com>
On Fri, Oct 31, 2025 at 03:37:39AM +0000, Xinyu Ruan via GitGitGadget wrote:
Show 5 quoted lines
> From: Xinyu Ruan <r200981113@gmail.com>
> 
> The debug ref backend (refs_be_debug) was missing the optimize
> function pointer, which caused a segmentation fault when running
> 'GIT_TRACE_REFS=1 git pack-refs --all' command.

Thanks for sending the patch! As far as I can see though it's redundant with Karthik's patch series that is currently cooking in 'seen' [1]. So once that's merged down we should be good.

Patrick
[1]: <20251020-refs-code-cleanup-v2-1-f5349ed0f6a5@gmail.com>
Previous: Xinyu Ruan via GitGitGadget
Message 2 of 2 in “refs: add missing optimize implementation for debug ref backend”
  1. refs: add missing optimize implementation for debug ref backendXinyu Ruan via GitGitGadget, Oct 31, 2025
  2. Patrick SteinhardtOct 31, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.