git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Prepare our git-p4 tests for running on APFS

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 14, 2019, 21:19 UTC
Message-ID
<pull.179.v2.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.179.git.gitgitgadget@gmail.com>

Yesterday, the macOS agents of Azure Pipelines were upgraded to Mojave, and since that does not support HFS+ anymore, everything will be upgraded to APFS.

As I just found yesterday, we have one test that fails on that filesystem (t9822, which is only run if Perforce's p4d is available).

The first patch adds a workaround, as I failed to find any way to finagle APFS into accepting that ISO-8859-1 encoded file name.

The second patch is a fix to make things compile on Mojave again, apparently Homebrew changed and the /usr/local/ directories need to be added to the compiler and linker flags explicitly. Maybe this is a gcc-8 only thing, as it seems to have affected only the osx-gcc job, not the osx-clang job.

Changes since v1:
 * Fix the tyop in the oneline of the first patch where it should talk about
   ISO-8859-1.
Johannes Schindelin (2):
  t9822: skip tests if file names cannot be ISO-8859-1 encoded
  macOS: make sure that gettext is found
 config.mak.uname                | 2 ++
 t/t9822-git-p4-path-encoding.sh | 7 +++++++
 2 files changed, 9 insertions(+)
base-commit: e35b8cb8e212e3557efc565157ceb5cbaaf0d87f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-179%2Fdscho%2Fskip-t9822-on-apfs-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-179/dscho/skip-t9822-on-apfs-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/179
Range-diff vs v1:
 1:  52681aee0a ! 1:  6161c76702 t9822: skip tests if file names cannot be ISO-8895-1 encoded
     @@ -1,6 +1,6 @@
      Author: Johannes Schindelin <johannes.schindelin@gmx.de>
      
     -    t9822: skip tests if file names cannot be ISO-8895-1 encoded
     +    t9822: skip tests if file names cannot be ISO-8859-1 encoded
      
          Most notably, it seems that macOS' APFS does not allow that.
      
 2:  f006524f78 = 2:  25be67b1b7 macOS: make sure that gettext is found
-- 
gitgitgadget
Previous: Johannes SchindelinNext: Johannes Schindelin via GitGitGadget
Message 6 of 11 in “Prepare our git-p4 tests for running on APFS”
  1. 0/2 Prepare our git-p4 tests for running on APFSJohannes Schindelin via GitGitGadget, Apr 12, 2019
  2. 2/2 macOS: make sure that gettext is foundJohannes Schindelin via GitGitGadget, Apr 12, 2019
  3. 1/2 t9822: skip tests if file names cannot be ISO-8895-1 encodedJohannes Schindelin via GitGitGadget, Apr 12, 2019
  4. Luke DiamandApr 13, 2019
  5. Johannes SchindelinApr 14, 2019
  6. 0/2 Prepare our git-p4 tests for running on APFSJohannes Schindelin via GitGitGadget, Apr 14, 2019
  7. 1/2 t9822: skip tests if file names cannot be ISO-8859-1 encodedJohannes Schindelin via GitGitGadget, Apr 14, 2019
  8. Johannes SchindelinApr 15, 2019
  9. Junio C HamanoApr 15, 2019
  10. Johannes SchindelinApr 17, 2019
  11. 2/2 macOS: make sure that gettext is foundJohannes Schindelin via GitGitGadget, Apr 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.