git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] macOS: make sure that gettext is found

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 12, 2019, 11:39 UTC
Message-ID
<f006524f78a881b4f4e06cb15b877f8a226a9843.1555069181.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.179.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

Due to reasons (some XCode versions seem to include gettext, some don't?), Homebrew does not expose the libraries and headers in /usr/local/ by default anymore.

Let's help find them again.
Note: for some reason, this is a change of behavior caused by the
upgrade to Mojave, identified in our Azure Pipeline; it seems that
Homebrew used to add the /usr/local/ directories to the include and link
search path before, but now it no longer does.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 config.mak.uname | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/config.mak.uname b/config.mak.uname
index 41e85fab1c..3605fead53 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -114,6 +114,8 @@ ifeq ($(uname_S),Darwin)
 	HAVE_BSD_SYSCTL = YesPlease
 	FREAD_READS_DIRECTORIES = UnfortunatelyYes
 	HAVE_NS_GET_EXECUTABLE_PATH = YesPlease
+	BASIC_CFLAGS += -I/usr/local/include
+	BASIC_LDFLAGS += -L/usr/local/lib
 endif
 ifeq ($(uname_S),SunOS)
 	NEEDS_SOCKET = YesPlease
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 2 of 11 in “Prepare our git-p4 tests for running on APFS”
  1. 0/2 Prepare our git-p4 tests for running on APFSJohannes Schindelin via GitGitGadget, Apr 12, 2019
  2. 2/2 macOS: make sure that gettext is foundJohannes Schindelin via GitGitGadget, Apr 12, 2019
  3. 1/2 t9822: skip tests if file names cannot be ISO-8895-1 encodedJohannes Schindelin via GitGitGadget, Apr 12, 2019
  4. Luke DiamandApr 13, 2019
  5. Johannes SchindelinApr 14, 2019
  6. 0/2 Prepare our git-p4 tests for running on APFSJohannes Schindelin via GitGitGadget, Apr 14, 2019
  7. 1/2 t9822: skip tests if file names cannot be ISO-8859-1 encodedJohannes Schindelin via GitGitGadget, Apr 14, 2019
  8. Johannes SchindelinApr 15, 2019
  9. Junio C HamanoApr 15, 2019
  10. Johannes SchindelinApr 17, 2019
  11. 2/2 macOS: make sure that gettext is foundJohannes Schindelin via GitGitGadget, Apr 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.