git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] doc: fix the max number of git show-branches shown

From
WGwonda-tea-coffee via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 6, 2024, 09:53 UTC
Message-ID
<pull.1757.v2.git.1720259599119.gitgitgadget@gmail.com>
In-Reply-To
<pull.1757.git.1720046185710.gitgitgadget@gmail.com>
From: wonda-tea-coffee <lagrange.resolvent@gmail.com>

The number to be displayed is calculated by the following defined in object.h.

```
  #define REV_SHIFT        2
  #define MAX_REVS        (FLAG_BITS - REV_SHIFT)
```

FLAG_BITS is currently 28, so 26 is the correct number.

Signed-off-by: Rikita Ishikawa <lagrange.resolvent@gmail.com>
---
    doc: fix the max number of git show-branches shown
    
    Changes since v1:
    
     * Explain in the commit message why "26" is the correct number.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1757
Range-diff vs v1:
 1:  b809d610a36 ! 1:  6fc335807d2 doc: fix the max number of git show-branches shown
     @@ Metadata
       ## Commit message ##
          doc: fix the max number of git show-branches shown
      
     -    Contrary to the number listed in the current document,
     -    only 26 are actually shown.
     +    The number to be displayed is calculated by the
     +    following defined in object.h.
      
     -    Signed-off-by: wonda-tea-coffee <lagrange.resolvent@gmail.com>
     +    ```
     +      #define REV_SHIFT        2
     +      #define MAX_REVS        (FLAG_BITS - REV_SHIFT)
     +    ```
     +
     +    FLAG_BITS is currently 28, so 26 is the correct
     +    number.
     +
     +    Signed-off-by: Rikita Ishikawa <lagrange.resolvent@gmail.com>
      
       ## Documentation/git-show-branch.txt ##
      @@ Documentation/git-show-branch.txt: Shows the commit ancestry graph starting from the commits named
 Documentation/git-show-branch.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt
index c771c897707..bc31d8b6d33 100644
--- a/Documentation/git-show-branch.txt
+++ b/Documentation/git-show-branch.txt
@@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named
 with <rev>s or <glob>s (or all refs under refs/heads
 and/or refs/tags) semi-visually.
 
-It cannot show more than 29 branches and commits at a time.
+It cannot show more than 26 branches and commits at a time.
 
 It uses `showbranch.default` multi-valued configuration items if
 no <rev> or <glob> is given on the command line.

base-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558
-- 
gitgitgadget
Previous: Junio C HamanoNext: Jeff King
Message 4 of 12 in “doc: fix the max number of git show-branches shown”
  1. doc: fix the max number of git show-branches shownwonda-tea-coffee via GitGitGadget, Jul 3, 2024
  2. Jeff KingJul 6, 2024
  3. Junio C HamanoJul 6, 2024
  4. doc: fix the max number of git show-branches shownwonda-tea-coffee via GitGitGadget, Jul 6, 2024
  5. Jeff KingJul 6, 2024
  6. doc: fix the max number of git show-branches shownRikita Ishikawa via GitGitGadget, Jul 7, 2024
  7. doc: fix the max number of git show-branches shownRikita Ishikawa via GitGitGadget, Jul 7, 2024
  8. rikita ishikawaJul 7, 2024
  9. Jeff KingJul 8, 2024
  10. rikita ishikawaJul 8, 2024
  11. doc: fix the max number of git show-branches shownRikita Ishikawa via GitGitGadget, Jul 8, 2024
  12. Junio C HamanoJul 8, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.