Re: [PATCH v2] doc: fix the max number of git show-branches shown

From: Jeff King <peff@peff.net>
Date: Jul 6, 2024, 23:14 UTC
Message-ID: <20240706231451.GD746087@coredump.intra.peff.net>
In-Reply-To: <pull.1757.v2.git.1720259599119.gitgitgadget@gmail.com>

On Sat, Jul 06, 2024 at 09:53:18AM +0000, wonda-tea-coffee via GitGitGadget wrote:

Show 14 quoted lines

> From: wonda-tea-coffee <lagrange.resolvent@gmail.com>
> 
> The number to be displayed is calculated by the
> following defined in object.h.
> 
> ```
>   #define REV_SHIFT        2
>   #define MAX_REVS        (FLAG_BITS - REV_SHIFT)
> ```
> 
> FLAG_BITS is currently 28, so 26 is the correct
> number.
> 
> Signed-off-by: Rikita Ishikawa <lagrange.resolvent@gmail.com>

Thanks, this version looks good to me. As Junio noted, we'd generally want the "From" to match the Sign-off (where the former is coming from the author name in the commit). You can either re-send, or if you give the OK, he might just fix it up as he applies.

-Peff