git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Remove MSys Support

From
HGHarshil Jani via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 2, 2023, 03:51 UTC
Message-ID
<pull.1433.v2.git.1675309898.gitgitgadget@gmail.com>
In-Reply-To
<pull.1433.git.1670274213.gitgitgadget@gmail.com>

I am trying to learn more about the git code base and came across the issue where the support of MSys environment was to be dropped. This patch is my first contribution towards it.

The msysGit and the MSys v1.x has been dropped into this patch and the USE_NED_ALLOCATOR variable was duplicated here in the implementation so its deduplication was also made in this patch.

Signed-off-by: Harshil-Jani harshiljani2002@gmail.com
Harshil-Jani (2):
  mingw: remove duplicate `USE_NED_ALLOCATOR` directive
  mingw: remove msysGit/MSYS1 support
 config.mak.uname | 86 ++++++++++++++++++++----------------------------
 1 file changed, 35 insertions(+), 51 deletions(-)
base-commit: 35a62bb5798092d491e6c7e688db6cb1418c9098
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1433%2FHarshil-Jani%2Fdrop-Msys-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1433/Harshil-Jani/drop-Msys-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1433
Range-diff vs v1:
 1:  bc79dfcc4d4 = 1:  bc79dfcc4d4 mingw: remove duplicate `USE_NED_ALLOCATOR` directive
 2:  e6d3d280a4f ! 2:  0c0289343fb mingw: remove msysGit/MSYS1 support
     @@ Metadata
       ## Commit message ##
          mingw: remove msysGit/MSYS1 support
      
     -    The msysGit (i.e. Git for Windows 1.x' SDK) is no longer used and the
     -    last known user for MSys1 + MinGW has switched to MSys2. So there was no
     -    reason to keep the msysGit/MSys1 config section. This Patch intends to
     -    remove the support of both the builds and throw an error on
     -    execution.
     -
     -    The output of `uname -r` if returns us with '1.' then it relates with MSys1
     -    build environment and msysGit which we don't want to continue ahead and thus
     -    an error can be expected.
     -
     -    The MSYS2 is currently used into the MinGW so we can get that part
     -    running directly without any conditionals required.
     +    MSys has long fallen behind MSYS2 in features like Unicode or
     +    x86_64 support or even security bug fixes, and is therefore no
     +    longer used by anyone in the Git developer community. The Git for
     +    Windows project itself started switching from MSys to MSYS2 early
     +    in 2015, i.e. about eight years ago. Let's drop supporting MSys as
     +    a development platform.
      
          Signed-off-by: Harshil-Jani <harshiljani2002@gmail.com>
      
-- 
gitgitgadget
Previous: Junio C HamanoNext: Harshil-Jani via GitGitGadget
Message 12 of 16 in “Remove MSys Support”
  1. 0/2 Remove MSys SupportHarshil Jani via GitGitGadget, Dec 5, 2022
  2. 1/2 mingw: remove duplicate `USE_NED_ALLOCATOR` directiveHarshil-Jani via GitGitGadget, Dec 5, 2022
  3. Junio C HamanoDec 18, 2022
  4. 2/2 mingw: remove msysGit/MSYS1 supportHarshil-Jani via GitGitGadget, Dec 5, 2022
  5. Junio C HamanoDec 18, 2022
  6. Junio C HamanoDec 18, 2022
  7. Johannes SchindelinJan 9, 2023
  8. Junio C HamanoJan 9, 2023
  9. Junio C HamanoDec 18, 2022
  10. Johannes SchindelinJan 9, 2023
  11. Junio C HamanoJan 9, 2023
  12. 0/2 Remove MSys SupportHarshil Jani via GitGitGadget, Feb 2, 2023
  13. 1/2 mingw: remove duplicate `USE_NED_ALLOCATOR` directiveHarshil-Jani via GitGitGadget, Feb 2, 2023
  14. 2/2 mingw: remove msysGit/MSYS1 supportHarshil-Jani via GitGitGadget, Feb 2, 2023
  15. Johannes SchindelinFeb 2, 2023
  16. Junio C HamanoFeb 2, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.