git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Remove MSys Support

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 9, 2023, 07:36 UTC
Message-ID
<9933d992-ffd3-b43c-559e-0de819408cda@gmx.de>
In-Reply-To
<xmqqmt7lxxr6.fsf@gitster.g>
Hi Junio,
On Sun, 18 Dec 2022, Junio C Hamano wrote:
Show 25 quoted lines
> "Harshil Jani via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > The msysGit and the MSys v1.x has been dropped into this patch and the
> > USE_NED_ALLOCATOR variable was duplicated here in the implementation so its
> > deduplication was also made in this patch.
> >
> > Signed-off-by: Harshil-Jani harshiljani2002@gmail.com
>
> Thanks, Harshil.
>
> I do not do Windows, so I sent a few drive-by comments to suggest
> improvements that may help to make the patch more understandable,
> but more importantly, I did not see the patch asking input from
> anybody who have worked on the port of Git to the Window system, so
> I ran the following
>
> $ git shortlog -sn --no-merges v2.39.0 -- compat/win\*\* compat/mingw.\* | head -5
>    100	Johannes Schindelin
>     56	Johannes Sixt
>     41	Karsten Blees
>     23	Erik Faye-Lund
>     13	Jeff Hostetler
>
> and then picked those names we still often see on the list to
> attract their attention.

I need to note that Harshil and I have been communicating about this patch before it was submitted. So here is my explicit ACK.

Ciao, Johannes

Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 16 in “Remove MSys Support”
  1. 0/2 Remove MSys SupportHarshil Jani via GitGitGadget, Dec 5, 2022
  2. 1/2 mingw: remove duplicate `USE_NED_ALLOCATOR` directiveHarshil-Jani via GitGitGadget, Dec 5, 2022
  3. Junio C HamanoDec 18, 2022
  4. 2/2 mingw: remove msysGit/MSYS1 supportHarshil-Jani via GitGitGadget, Dec 5, 2022
  5. Junio C HamanoDec 18, 2022
  6. Junio C HamanoDec 18, 2022
  7. Johannes SchindelinJan 9, 2023
  8. Junio C HamanoJan 9, 2023
  9. Junio C HamanoDec 18, 2022
  10. Johannes SchindelinJan 9, 2023
  11. Junio C HamanoJan 9, 2023
  12. 0/2 Remove MSys SupportHarshil Jani via GitGitGadget, Feb 2, 2023
  13. 1/2 mingw: remove duplicate `USE_NED_ALLOCATOR` directiveHarshil-Jani via GitGitGadget, Feb 2, 2023
  14. 2/2 mingw: remove msysGit/MSYS1 supportHarshil-Jani via GitGitGadget, Feb 2, 2023
  15. Johannes SchindelinFeb 2, 2023
  16. Junio C HamanoFeb 2, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.