git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] a few config integer parsing fixes

From
PGPhillip Wood via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 21, 2022, 13:45 UTC
Message-ID
<pull.1389.git.1666359915.gitgitgadget@gmail.com>

This series fixes some issues I noticed when reading the integer parsing code in config.c

 * git_parse_unsigned() does not reject negative values
 * git_parse_[un]signed() accept a units specifier without any digits
 * git_parse_signed() has in integer overflow when parsing MAXINT_MIN

Ideally we'd have a test tool to unit test functions like this, I haven't found time to write that yet. cc'ing René for patch 3 as he was the last person to touch that code.

Phillip Wood (3):
  git_parse_unsigned: reject negative values
  config: require at least one digit when parsing numbers
  git_parse_signed(): avoid integer overflow
 config.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)
base-commit: e85701b4af5b7c2a9f3a1b07858703318dce365d
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1389%2Fphillipwood%2Fconfig-integer-parsing-fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1389/phillipwood/config-integer-parsing-fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1389
-- 
gitgitgadget
Next: Phillip Wood via GitGitGadget
Message 1 of 27 in “a few config integer parsing fixes”
  1. 0/3 a few config integer parsing fixesPhillip Wood via GitGitGadget, Oct 21, 2022
  2. 1/3 git_parse_unsigned: reject negative valuesPhillip Wood via GitGitGadget, Oct 21, 2022
  3. Junio C HamanoOct 21, 2022
  4. Jeff KingOct 21, 2022
  5. Junio C HamanoOct 22, 2022
  6. 2/3 config: require at least one digit when parsing numbersPhillip Wood via GitGitGadget, Oct 21, 2022
  7. Junio C HamanoOct 21, 2022
  8. Phillip WoodOct 25, 2022
  9. Junio C HamanoOct 25, 2022
  10. Jeff KingOct 21, 2022
  11. Junio C HamanoOct 22, 2022
  12. Jeff KingOct 22, 2022
  13. Junio C HamanoOct 22, 2022
  14. Phillip WoodOct 25, 2022
  15. 3/3 git_parse_signed(): avoid integer overflowPhillip Wood via GitGitGadget, Oct 21, 2022
  16. Junio C HamanoOct 21, 2022
  17. René ScharfeOct 22, 2022
  18. Junio C HamanoOct 22, 2022
  19. René ScharfeOct 23, 2022
  20. Phillip WoodOct 25, 2022
  21. René ScharfeOct 26, 2022
  22. 0/3 a few config integer parsing fixesPhillip Wood via GitGitGadget, Nov 9, 2022
  23. 1/3 git_parse_unsigned: reject negative valuesPhillip Wood via GitGitGadget, Nov 9, 2022
  24. Ævar Arnfjörð BjarmasonNov 9, 2022
  25. 2/3 config: require at least one digit when parsing numbersPhillip Wood via GitGitGadget, Nov 9, 2022
  26. 3/3 git_parse_signed(): avoid integer overflowPhillip Wood via GitGitGadget, Nov 9, 2022
  27. Taylor BlauNov 10, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.