git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] Correct credential helper discrepancies handling input

From
Matthew John Cheetham via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 22, 2022, 16:59 UTC
Message-ID
<pull.1363.git.1663865974.gitgitgadget@gmail.com>

Whilst working in the credential helper and auth space I happened to notice that the behaviour of some of the credential helpers in contrib/credential/ is not consistent.

Specifically both the git-credential-wincred and git-credential-netrc helpers die when they receive unknown credential property keys, which is contrary to the behaviour of all the other in-tree helpers including: git-credential-cache, -store, -libsecret, -gnome-keyring, -osxkeychain.

Also update the git-credential-osxkeychain helper to include a comment making it's behaviour explicit in ignoring unknown keys, as per other helpers.

Matthew John Cheetham (3):
  wincred: ignore unknown lines (do not die)
  netrc: ignore unknown lines (do not die)
  osxkeychain: clarify that we ignore unknown lines
 contrib/credential/netrc/git-credential-netrc.perl         | 5 ++++-
 .../credential/osxkeychain/git-credential-osxkeychain.c    | 5 +++++
 contrib/credential/wincred/git-credential-wincred.c        | 7 +++++--
 3 files changed, 14 insertions(+), 3 deletions(-)
base-commit: dd3f6c4cae7e3b15ce984dce8593ff7569650e24
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1363%2Fmjcheetham%2Fcredhelper-fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1363/mjcheetham/credhelper-fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1363
-- 
gitgitgadget
Next: Matthew John Cheetham via GitGitGadget
Message 1 of 8 in “Correct credential helper discrepancies handling input”
  1. 0/3 Correct credential helper discrepancies handling inputMatthew John Cheetham via GitGitGadget, Sep 22, 2022
  2. 1/3 wincred: ignore unknown lines (do not die)Matthew John Cheetham via GitGitGadget, Sep 22, 2022
  3. Junio C HamanoSep 22, 2022
  4. Jeff KingSep 22, 2022
  5. 2/3 netrc: ignore unknown lines (do not die)Matthew John Cheetham via GitGitGadget, Sep 22, 2022
  6. 3/3 osxkeychain: clarify that we ignore unknown linesMatthew John Cheetham via GitGitGadget, Sep 22, 2022
  7. Derrick StoleeSep 22, 2022
  8. Jeff KingSep 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.