git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Correct credential helper discrepancies handling input

From
Jeff King <peff@peff.net>
Date
Sep 22, 2022, 22:11 UTC
Message-ID
<Yyzdp21kNuLqhM0X@coredump.intra.peff.net>
In-Reply-To
<pull.1363.git.1663865974.gitgitgadget@gmail.com>
On Thu, Sep 22, 2022 at 04:59:31PM +0000, Matthew John Cheetham via GitGitGadget wrote:
Show 12 quoted lines
> Whilst working in the credential helper and auth space I happened to notice
> that the behaviour of some of the credential helpers in contrib/credential/
> is not consistent.
> 
> Specifically both the git-credential-wincred and git-credential-netrc
> helpers die when they receive unknown credential property keys, which is
> contrary to the behaviour of all the other in-tree helpers including:
> git-credential-cache, -store, -libsecret, -gnome-keyring, -osxkeychain.
> 
> Also update the git-credential-osxkeychain helper to include a comment
> making it's behaviour explicit in ignoring unknown keys, as per other
> helpers.

Thanks, I think these are all sensible changes. The new behavior matches the original vision of the helper protocol. But more importantly, it brings them in line with all of the _other_ existing helpers. Which is no coincidence, since the designer of the protocol wrote most of them. ;)

I haven't had a chance to look carefully at the rest of your larger series yet, but I think these are a nice standalone improvement regardless of what happens there.

-Peff
Previous: Derrick Stolee
Message 8 of 8 in “Correct credential helper discrepancies handling input”
  1. 0/3 Correct credential helper discrepancies handling inputMatthew John Cheetham via GitGitGadget, Sep 22, 2022
  2. 1/3 wincred: ignore unknown lines (do not die)Matthew John Cheetham via GitGitGadget, Sep 22, 2022
  3. Junio C HamanoSep 22, 2022
  4. Jeff KingSep 22, 2022
  5. 2/3 netrc: ignore unknown lines (do not die)Matthew John Cheetham via GitGitGadget, Sep 22, 2022
  6. 3/3 osxkeychain: clarify that we ignore unknown linesMatthew John Cheetham via GitGitGadget, Sep 22, 2022
  7. Derrick StoleeSep 22, 2022
  8. Jeff KingSep 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.