Re: [PATCH] describe: drop early return for max_candidates == 0
- From
Josh Steadmon <steadmon@google.com>
- Date
- Dec 5, 2024, 22:28 UTC
- Message-ID
- <plncccgcchrmspkelepacifqpfua7nzsb4y5xzjv4vzc3p36yr@r63i2xo6avba>
- In-Reply-To
- <20241205201449.GA2635755@coredump.intra.peff.net>
On 2024.12.05 15:14, Jeff King wrote:
Show 13 quoted lines
> On Wed, Dec 04, 2024 at 06:27:50PM -0500, Jeff King wrote: > > > > Subject: Re: [PATCH] fixup! describe: stop traversing when we run out of names > > > > This commit is already in 'next', so it's too late to squash in a change > > (though I'd have done this separately anyway, as it's already an issue > > for a manual --candidates=0 setting, as unlikely as that is). > > > > Can you re-send with a full commit message? > > Actually, after thinking on this a bit more, I think the solution below > is a bit more elegant. This can go on top of jk/describe-perf. >
Thanks, and sorry for not replying earlier, I got distracted by a different $DAYJOB breakage: https://lore.kernel.org/git/b41ae080654a3603af09801018df539f656cf9d8.1733430345.git.steadmon@google.com/