Re: [PATCH 0/4] perf improvements for git-describe with few tags
- From
Josh Steadmon <steadmon@google.com>
- Date
- Dec 4, 2024, 23:04 UTC
- Message-ID
- <fxbv4ihz4sgdfwtq4vkadntank2lzwkt6abgipuojhumjmuxjs@fegutv3kcamo>
- In-Reply-To
- <xmqqldx61t65.fsf@gitster.g>
On 2024.11.26 14:05, Junio C Hamano wrote:
Show 17 quoted lines
> Jeff King <peff@peff.net> writes: > > > So here's the series I came up with, which starts by adjusting the tests > > to be resilient to the later changes, but also to show the existing > > failure mode. > > > > And then the rest of the patches add the performance improvements we've > > been discussing in the thread. > > So, this did not get any comments, but I had a time to read it over, > and did not find anything suspicious in there. > > Let me mark it for 'next', this time for real, in the What's cooking > draft I have. > > Thanks. >
This breaks the case of `git describe --always $SOME_HASH` (we hit the die at builtin/describe.c:340) when there are no tags in the repo. I can send a test case and a small fix shortly.