[PATCH v3 19/26] submodule--helper: fix a memory leak in print_status()
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jul 21, 2022, 19:13 UTC
- Message-ID
- <patch-v3-19.26-7ef89abed86-20220721T191249Z-avarab@gmail.com>
- In-Reply-To
- <cover-v3-00.26-00000000000-20220721T191249Z-avarab@gmail.com>
Fix a leak in print_status(), the compute_rev_name() function implemented in this file will return a strbuf_detach()'d value, or NULL.
This leak has existed since this code was added in a9f8a37584a (submodule: port submodule subcommand 'status' from shell to C, 2017-10-06), but in 0b5e2ea7cf3 (submodule--helper: don't print null in 'submodule status', 2018-04-18) we added a "const" intermediate variable for the return value, that "const" should be removed.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- builtin/submodule--helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 0fb720d3a16..4decbdcdc5c 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -637,10 +637,11 @@ static void print_status(unsigned int flags, char state, const char *path, printf("%c%s %s", state, oid_to_hex(oid), displaypath); if (state == ' ' || state == '+') { - const char *name = compute_rev_name(path, oid_to_hex(oid)); + char *name = compute_rev_name(path, oid_to_hex(oid)); if (name) printf(" (%s)", name); + free(name); } printf("\n");
-- 2.37.1.1095.g0bd6f54ba8a