Re: [PATCH 02/11] submodule--helper: replace memset() with { 0 }-initialization
- From
Glen Choo <chooglen@google.com>
- Date
- Jul 13, 2022, 21:00 UTC
- Message-ID
- <kl6lfsj4684n.fsf@chooglen-macbookpro.roam.corp.google.com>
- In-Reply-To
- <patch-02.11-4049362e9b4-20220713T131601Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 5 quoted lines
> Use the less verbose { 0 }-initialization syntax rather than memset()
> in builtin/submodule--helper.c, this doesn't make a difference in
> terms of behavior, but as we're about to modify adjacent code makes
> this more consistent, and lets us avoid worrying about when the
> memset() happens v.s. a "goto cleanup".Ok. I wonder if we could reduce this kind of churn in the future by adding this to CodingGuidelines, e.g. "always use { 0 } for stack variables". Tangentially, do we require { NULL } when the first element is a pointer? (I'm not sure because this isn't in CodingGuidelines either AFAICT.)
Show 45 quoted lines
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> builtin/submodule--helper.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index fac52ade5e1..73717be957c 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1744,7 +1744,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
> {
> int dissociate = 0, quiet = 0, progress = 0, require_init = 0;
> struct module_clone_data clone_data = MODULE_CLONE_DATA_INIT;
> - struct list_objects_filter_options filter_options;
> + struct list_objects_filter_options filter_options = { 0 };
>
> struct option module_clone_options[] = {
> OPT_STRING(0, "prefix", &clone_data.prefix,
> @@ -1786,7 +1786,6 @@ static int module_clone(int argc, const char **argv, const char *prefix)
> NULL
> };
>
> - memset(&filter_options, 0, sizeof(filter_options));
> argc = parse_options(argc, argv, prefix, module_clone_options,
> git_submodule_helper_usage, 0);
>
> @@ -2563,7 +2562,7 @@ static int module_update(int argc, const char **argv, const char *prefix)
> {
> struct pathspec pathspec;
> struct update_data opt = UPDATE_DATA_INIT;
> - struct list_objects_filter_options filter_options;
> + struct list_objects_filter_options filter_options = { 0 };
> int ret;
>
> struct option module_update_options[] = {
> @@ -2623,7 +2622,6 @@ static int module_update(int argc, const char **argv, const char *prefix)
> update_clone_config_from_gitmodules(&opt.max_jobs);
> git_config(git_update_clone_config, &opt.max_jobs);
>
> - memset(&filter_options, 0, sizeof(filter_options));
> argc = parse_options(argc, argv, prefix, module_update_options,
> git_submodule_helper_usage, 0);
>
> --
> 2.37.0.932.g7b7031e73bc