git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/4] object.h: use BUG(...) no die("BUG: ...") in lookup_object_by_type()

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 7, 2021, 11:05 UTC
Message-ID
<patch-v2-4.4-aaf952a9ede-20211207T110440Z-avarab@gmail.com>
In-Reply-To
<cover-v2-0.4-00000000000-20211207T110440Z-avarab@gmail.com>

Adjust code added in 7463064b280 (object.h: add lookup_object_by_type() function, 2021-06-22) to use the BUG() function.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/object.c b/object.c
index 23a24e678a8..4be82c1e7bc 100644
--- a/object.c
+++ b/object.c
@@ -199,7 +199,7 @@ struct object *lookup_object_by_type(struct repository *r,
 	case OBJ_BLOB:
 		return (struct object *)lookup_blob(r, oid);
 	default:
-		die("BUG: unknown object type %d", type);
+		BUG("unknown object type %d", type);
 	}
 }
 
-- 
2.34.1.898.g5a552c2e5f0
Previous: Ævar Arnfjörð Bjarmason
Message 11 of 11 in “replace die("BUG: ...") with BUG("...")”
  1. 0/2 replace die("BUG: ...") with BUG("...")Ævar Arnfjörð Bjarmason, Dec 6, 2021
  2. 1/2 pack-objects: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 6, 2021
  3. 2/2 strbuf.h: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 6, 2021
  4. Junio C HamanoDec 6, 2021
  5. Ævar Arnfjörð BjarmasonDec 7, 2021
  6. 3/2 replace die("BUG: ...") with BUG("...")Junio C Hamano, Dec 7, 2021
  7. 0/4 replace die("BUG: ...") with BUG("...")Ævar Arnfjörð Bjarmason, Dec 7, 2021
  8. 1/4 pack-objects: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 7, 2021
  9. 2/4 strbuf.h: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 7, 2021
  10. 3/4 pathspec: use BUG(...) not die("BUG:%s:%d....", <file>, <line>)Ævar Arnfjörð Bjarmason, Dec 7, 2021
  11. 4/4 object.h: use BUG(...) no die("BUG: ...") in lookup_object_by_type()Ævar Arnfjörð Bjarmason, Dec 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.