git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] replace die("BUG: ...") with BUG("...")

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 7, 2021, 11:00 UTC
Message-ID
<211207.86a6hcptjs.gmgdl@evledraar.gmail.com>
In-Reply-To
<xmqqv901fu8m.fsf@gitster.g>
On Mon, Dec 06 2021, Junio C Hamano wrote:
Show 7 quoted lines
> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> A trivial clean-up to change a couple of die() uses to BUG() where
>> appropriate.
>
> Makes sense.  I wonder contrib/coccinelle/ can help us maintain
> them, though.

I tried to come up with a rule for this after browsing around in linux's sources & coccicheck's own test cases, but didn't find any example I could adapt. It's rather thin on string munging like that, and I don't know spatch well enough.

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 11 in “replace die("BUG: ...") with BUG("...")”
  1. 0/2 replace die("BUG: ...") with BUG("...")Ævar Arnfjörð Bjarmason, Dec 6, 2021
  2. 1/2 pack-objects: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 6, 2021
  3. 2/2 strbuf.h: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 6, 2021
  4. Junio C HamanoDec 6, 2021
  5. Ævar Arnfjörð BjarmasonDec 7, 2021
  6. 3/2 replace die("BUG: ...") with BUG("...")Junio C Hamano, Dec 7, 2021
  7. 0/4 replace die("BUG: ...") with BUG("...")Ævar Arnfjörð Bjarmason, Dec 7, 2021
  8. 1/4 pack-objects: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 7, 2021
  9. 2/4 strbuf.h: use BUG(...) not die("BUG: ...")Ævar Arnfjörð Bjarmason, Dec 7, 2021
  10. 3/4 pathspec: use BUG(...) not die("BUG:%s:%d....", <file>, <line>)Ævar Arnfjörð Bjarmason, Dec 7, 2021
  11. 4/4 object.h: use BUG(...) no die("BUG: ...") in lookup_object_by_type()Ævar Arnfjörð Bjarmason, Dec 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.