[PATCH v2 16/21] refs API: make refs_ref_exists() not set errno
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Oct 16, 2021, 09:39 UTC
- Message-ID
- <patch-v2-16.21-c4e87181121-20211016T093845Z-avarab@gmail.com>
- In-Reply-To
- <cover-v2-00.21-00000000000-20211016T093845Z-avarab@gmail.com>
Move refs_ref_exists from the legacy refs_resolve_ref_unsafe() to the new refs_werrres_ref_unsafe(). I have read its callers and determined that they don't care about errno being set, in particular:
git grep -W -w -e refs_ref_exists -e ref_exists
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- refs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c index 09452b5e413..8d5a76fbf29 100644 --- a/refs.c +++ b/refs.c @@ -309,7 +309,9 @@ int read_ref(const char *refname, struct object_id *oid) int refs_ref_exists(struct ref_store *refs, const char *refname) { - return !!refs_resolve_ref_unsafe(refs, refname, RESOLVE_REF_READING, NULL, NULL); + int ignore_errno; + return !!refs_werrres_ref_unsafe(refs, refname, RESOLVE_REF_READING, + NULL, NULL, &ignore_errno); } int ref_exists(const char *refname)
-- 2.33.1.1338.g20da966911a