[PATCH v2 09/21] refs API: make resolve_gitlink_ref() not set errno

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 16, 2021, 09:39 UTC
Message-ID: <patch-v2-09.21-65beb51ae4e-20211016T093845Z-avarab@gmail.com>
In-Reply-To: <cover-v2-00.21-00000000000-20211016T093845Z-avarab@gmail.com>

I have carefully read the upstream callers of resolve_gitlink_ref() and determined that they don't care about errno.

So let's move away from the errno-setting refs_resolve_ref_unsafe() wrapper to refs_werrres_ref_unsafe(), and explicitly ignore the errno it sets for us.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 refs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/refs.c b/refs.c
index 80b85d244d2..dc6ed561492 100644
--- a/refs.c
+++ b/refs.c
@@ -1791,14 +1791,15 @@ int resolve_gitlink_ref(const char *submodule, const char *refname,
 {
 	struct ref_store *refs;
 	int flags;
+	int ignore_errno;
 
 	refs = get_submodule_ref_store(submodule);
 
 	if (!refs)
 		return -1;
 
-	if (!refs_resolve_ref_unsafe(refs, refname, 0, oid, &flags) ||
-	    is_null_oid(oid))
+	if (!refs_werrres_ref_unsafe(refs, refname, 0, oid, &flags,
+				     &ignore_errno) || is_null_oid(oid))
 		return -1;
 	return 0;
 }

-- 
2.33.1.1338.g20da966911a