git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] misc *.c: use designated initializers for struct assignments

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 17, 2022, 17:27 UTC
Message-ID
<patch-3.5-11bfe9fabb4-20220317T171618Z-avarab@gmail.com>
In-Reply-To
<cover-0.5-00000000000-20220317T171618Z-avarab@gmail.com>

Change a few miscellaneous non-designated initializer assignments to use designated initializers.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 attr.c        | 2 +-
 notes-merge.c | 1 +
 object-file.c | 9 +++++----
 3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/attr.c b/attr.c
index 79adaa50ea1..9ad12578cce 100644
--- a/attr.c
+++ b/attr.c
@@ -80,7 +80,7 @@ static int attr_hash_entry_cmp(const void *unused_cmp_data,
  * Access to this dictionary must be surrounded with a mutex.
  */
 static struct attr_hashmap g_attr_hashmap = {
-	HASHMAP_INIT(attr_hash_entry_cmp, NULL)
+	.map = HASHMAP_INIT(attr_hash_entry_cmp, NULL),
 };
 
 /*
diff --git a/notes-merge.c b/notes-merge.c
index 878b6c571b9..b4cc594a790 100644
--- a/notes-merge.c
+++ b/notes-merge.c
@@ -113,6 +113,7 @@ static struct notes_merge_pair *find_notes_merge_pair_pos(
 }
 
 static struct object_id uninitialized = {
+	.hash =
 	"\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff" \
 	"\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff"
 };
diff --git a/object-file.c b/object-file.c
index bdc5cbdd386..f0a75b3ff1e 100644
--- a/object-file.c
+++ b/object-file.c
@@ -274,10 +274,11 @@ static struct cached_object {
 static int cached_object_nr, cached_object_alloc;
 
 static struct cached_object empty_tree = {
-	{ EMPTY_TREE_SHA1_BIN_LITERAL },
-	OBJ_TREE,
-	"",
-	0
+	.oid = {
+		.hash = EMPTY_TREE_SHA1_BIN_LITERAL,
+	},
+	.type = OBJ_TREE,
+	.buf = "",
 };
 
 static struct cached_object *find_cached_object(const struct object_id *oid)
-- 
2.35.1.1384.g7d2906948a1
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 4 of 11 in “refs: designated init & missing debug in ps/fetch-mirror-optim”
  1. 0/5 refs: designated init & missing debug in ps/fetch-mirror-optimÆvar Arnfjörð Bjarmason, Mar 17, 2022
  2. 1/5 refs: use designated initializers for "struct ref_storage_be"Ævar Arnfjörð Bjarmason, Mar 17, 2022
  3. 2/5 refs: use designated initializers for "struct ref_iterator_vtable"Ævar Arnfjörð Bjarmason, Mar 17, 2022
  4. 3/5 misc *.c: use designated initializers for struct assignmentsÆvar Arnfjörð Bjarmason, Mar 17, 2022
  5. 4/5 packed-backend: remove stub BUG(...) functionsÆvar Arnfjörð Bjarmason, Mar 17, 2022
  6. Junio C HamanoMar 17, 2022
  7. 5/5 refs debug: add a wrapper for "read_symbolic_ref"Ævar Arnfjörð Bjarmason, Mar 17, 2022
  8. Han-Wen NienhuysMar 17, 2022
  9. Ævar Arnfjörð BjarmasonMar 18, 2022
  10. Patrick SteinhardtMar 21, 2022
  11. Junio C HamanoMar 21, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.