Re: [PATCH 0/5] refs: designated init & missing debug in ps/fetch-mirror-optim

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 21, 2022, 11:10 UTC
Message-ID: <YjhdOUEG1RbWDApX@ncase>
In-Reply-To: <CAFQ2z_M7-D4ZCJbj8JituTbR3d7ocRHd=ObdZUnmE=WD7qW0cg@mail.gmail.com>

On Thu, Mar 17, 2022 at 06:45:13PM +0100, Han-Wen Nienhuys wrote:

Show 11 quoted lines

> On Thu, Mar 17, 2022 at 6:27 PM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
> > Aside: It seems that the GIT_TRACE_REFS facility has been broken since
> > it was added, i.e. running the test site with e.g.:
> >
> >     GIT_TRACE_REFS=/tmp/log.txt make test
> 
> I wasn't aware that this is even possible. I've only used it with
> GIT_TRACE_REFS=1
> 
> I looked over your patches and they LGTM.

Seconded, the patches look good to me.

Patrick