[PATCH 3/3] SubmittingPatches: remove pine-specific hints from MUA hints
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 12, 2021, 08:45 UTC
- Message-ID
- <patch-3.3-9da5bc4a0c-20210512T084137Z-avarab@gmail.com>
- In-Reply-To
- <cover-0.3-0000000000-20210512T084137Z-avarab@gmail.com>
Remove the whole section about configuring pine with no-strip-whitespace-before-send.
There hasn't been a release of Pine since late 2005, in Alpine the no-strip-whitespace-before-send switch is already the default.
This documentation was initially added in 9740d289ee7 (Update SubmittingPatches to add MUA specific notes., 2005-08-26), at this point it's safe to say that it's not useful to anyone anymore, let's remove it.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Documentation/SubmittingPatches | 56 --------------------------------- 1 file changed, 56 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 2aa217da9c..e616d20556 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -498,62 +498,6 @@ first patch.\n", if you really want to put in the patch e-mail, should come after the three-dash line that signals the end of the commit message. - -=== Pine - -(Johannes Schindelin) - -.... -I don't know how many people still use pine, but for those poor -souls it may be good to mention that the quell-flowed-text is -needed for recent versions. - -... the "no-strip-whitespace-before-send" option, too. AFAIK it -was introduced in 4.60. -.... - -(Linus Torvalds) - -.... -And 4.58 needs at least this. - -diff-tree 8326dd8350be64ac7fc805f6563a1d61ad10d32c (from e886a61f76edf5410573e92e38ce22974f9c40f1) -Author: Linus Torvalds <torvalds@g5.osdl.org> -Date: Mon Aug 15 17:23:51 2005 -0700 - - Fix pine whitespace-corruption bug - - There's no excuse for unconditionally removing whitespace from - the pico buffers on close. - -diff --git a/pico/pico.c b/pico/pico.c ---- a/pico/pico.c -+++ b/pico/pico.c -@@ -219,7 +219,9 @@ PICO *pm; - switch(pico_all_done){ /* prepare for/handle final events */ - case COMP_EXIT : /* already confirmed */ - packheader(); -+#if 0 - stripwhitespace(); -+#endif - c |= COMP_EXIT; - break; -.... - -(Daniel Barkalow) - -.... -> A patch to SubmittingPatches, MUA specific help section for -> users of Pine 4.63 would be very much appreciated. - -Ah, it looks like a recent version changed the default behavior to do the -right thing, and inverted the sense of the configuration option. (Either -that or Gentoo did it.) So you need to set the -"no-strip-whitespace-before-send" option, unless the option you have is -"strip-whitespace-before-send", in which case you should avoid checking -it. -.... - === Thunderbird, KMail, GMail See the MUA-SPECIFIC HINTS section of linkgit:git-format-patch[1].
-- 2.31.1.909.g789bb6d90e