[PATCH v2 0/3] SubmittingPatches: a few unrelated minor fixes
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jun 7, 2021, 11:03 UTC
- Message-ID
- <cover-0.3-0000000000-20210607T110044Z-avarab@gmail.com>
- In-Reply-To
- <cover-0.3-0000000000-20210512T084137Z-avarab@gmail.com>
A few minor updates to SubmittingPatches spotted while paging through it the other day (or other month, given the delay until v2).
See https://lore.kernel.org/git/cover-0.3-0000000000-20210512T084137Z-avarab@gmail.com/ for the v1 discussion. This hopefully addresses all the outstanding comments with it.
Ævar Arnfjörð Bjarmason (3): SubmittingPatches: move discussion of Signed-off-by above "send" SubmittingPatches: replace discussion of Travis with GitHub Actions SubmittingPatches: remove pine-specific hints from MUA hints
Documentation/SubmittingPatches | 256 ++++++++++++-------------------- 1 file changed, 97 insertions(+), 159 deletions(-)
Range-diff against v1:
1: d18a3caa07 = 1: 9fa5437bb5 SubmittingPatches: move discussion of Signed-off-by above "send"
2: 7add00cc87 ! 2: 7d5d2854e3 SubmittingPatches: replace discussion of Travis with GitHub Actions
@@ Documentation/SubmittingPatches: the feature triggers the new behavior when it s
-on open source projects), you can use their Travis CI integration to
-test your changes on Linux, Mac (and hopefully soon Windows). See
-GitHub-Travis CI hints section for details.
-+If you have an account at GitHub pushing to a fork of
-+https://github.com/git/git will use their CI integration to test your
-+changes on Linux, Mac and Windows. See the GitHub CI section for details.
++Pushing to a fork of https://github.com/git/git will use their CI
++integration to test your changes on Linux, Mac and Windows. See the
++GitHub CI section for details.
Do not forget to update the documentation to describe the updated
behavior and make sure that the resulting documentation set formats
@@ Documentation/SubmittingPatches: their trees themselves.
-source projects), you can use Travis CI to test your changes on Linux,
-Mac (and hopefully soon Windows). You can find a successful example
-test build here: https://travis-ci.org/git/git/builds/120473209
-+With an account at GitHub you can use GitHub CI to test your changes
++With an account at GitHub, you can use GitHub CI to test your changes
+on Linux, Mac and Windows. See
+https://github.com/git/git/actions/workflows/main.yml for examples of
+recent CI runs.
@@ Documentation/SubmittingPatches: Follow these steps for the initial setup:
+can also download "Artifacts" which are tarred (or zipped) archives
+with test data relevant for debugging.
+
-+Then fix the problem and push your fix to your Github fork. This will
++Then fix the problem and push your fix to your GitHub fork. This will
+trigger a new CI build to ensure all tests pass.
[[mua]]
3: 9da5bc4a0c ! 3: a61885a198 SubmittingPatches: remove pine-specific hints from MUA hints
@@ Metadata
## Commit message ##
SubmittingPatches: remove pine-specific hints from MUA hints
- Remove the whole section about configuring pine with
- no-strip-whitespace-before-send.
+ Replace the whole section about configuring pine with
+ no-strip-whitespace-before-send with a note that users should use
+ another MUA instead.
There hasn't been a release of Pine since late 2005, in Alpine the
no-strip-whitespace-before-send switch is already the default.
This documentation was initially added in 9740d289ee7 (Update
- SubmittingPatches to add MUA specific notes., 2005-08-26), at this
+ SubmittingPatches to add MUA specific notes., 2005-08-26). At this
point it's safe to say that it's not useful to anyone anymore, let's
remove it.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
## Documentation/SubmittingPatches ##
-@@ Documentation/SubmittingPatches: first patch.\n", if you really want to put in the patch e-mail,
- should come after the three-dash line that signals the end of the
- commit message.
+@@ Documentation/SubmittingPatches: commit message.
+
+ === Pine
--
--=== Pine
--
-(Johannes Schindelin)
-
-....
@@ -219,7 +219,9 @@ PICO *pm;
-"strip-whitespace-before-send", in which case you should avoid checking
-it.
-....
--
++Abandoned by its uptsream and has known flowed text bugs, use its
++successor alpine or another MUA instead.
+
=== Thunderbird, KMail, GMail
- See the MUA-SPECIFIC HINTS section of linkgit:git-format-patch[1].-- 2.32.0.rc3.434.gd8aed1f08a7