git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/10] CI: have "static-analysis" run "check-builtins", not "documentation"

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 14, 2022, 19:39 UTC
Message-ID
<patch-10.10-5ef362505c1-20220714T193808Z-avarab@gmail.com>
In-Reply-To
<cover-00.10-00000000000-20220714T193808Z-avarab@gmail.com>

Move the "make check-builtins" check from the "documentation" job to the "static-analysis" job.

The "check-builtins" target added in c74390e4a1d (cherry is built-in, do not ship git-cherry.sh, 2006-11-05) is unrelated to the documentation, so it's odd that b98712b9aa9 (travis-ci: build documentation, 2016-05-04) added it to the "documentation" job.

Let's just move it to the "ci-static-analysis" target, and while we're at it improve the output with $(QUIET_CHECK).

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Makefile                 | 3 ++-
 ci/test-documentation.sh | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index c328e190d64..c2b0a728df5 100644
--- a/Makefile
+++ b/Makefile
@@ -3520,7 +3520,7 @@ check-docs::
 ### Make sure built-ins do not have dups and listed in git.c
 #
 check-builtins::
-	./check-builtins.sh
+	$(QUIET_CHECK)./check-builtins.sh
 
 ### Test suite coverage testing
 #
@@ -3615,6 +3615,7 @@ ci-check-directional-formatting:
 
 .PHONY: ci-static-analysis
 ci-static-analysis: ci-check-directional-formatting
+ci-static-analysis: check-builtins
 ci-static-analysis: check-coccicheck
 ci-static-analysis: hdr-check
 ci-static-analysis: check-pot
diff --git a/ci/test-documentation.sh b/ci/test-documentation.sh
index 9e0652c30dd..41e2b126311 100755
--- a/ci/test-documentation.sh
+++ b/ci/test-documentation.sh
@@ -14,7 +14,6 @@ filter_log () {
 	    "$1"
 }
 
-make check-builtins
 make check-docs
 
 # Build docs with AsciiDoc
-- 
2.37.1.996.g651fc6e809f
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 10 of 11 in “ci: make it easy to run locally, part 1”
  1. 00/10 ci: make it easy to run locally, part 1Ævar Arnfjörð Bjarmason, Jul 14, 2022
  2. 01/10 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, Jul 14, 2022
  3. 02/10 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, Jul 14, 2022
  4. 03/10 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, Jul 14, 2022
  5. 04/10 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, Jul 14, 2022
  6. 05/10 CI/lib.sh: stop adding leading whitespace to $MAKEFLAGSÆvar Arnfjörð Bjarmason, Jul 14, 2022
  7. 06/10 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, Jul 14, 2022
  8. 07/10 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, Jul 14, 2022
  9. 08/10 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, Jul 14, 2022
  10. 10/10 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, Jul 14, 2022
  11. 09/10 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, Jul 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.