git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/10] CI: don't have "git grep" invoke a pager in tree content check

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 14, 2022, 19:39 UTC
Message-ID
<patch-08.10-8bcaeb1dd79-20220714T193808Z-avarab@gmail.com>
In-Reply-To
<cover-00.10-00000000000-20220714T193808Z-avarab@gmail.com>

Fix the omission of not adding "-P" (a.k.a. "--no-pager") to the "git" invocation that spaws "git grep", added in 0e7696c64db (ci: disallow directional formatting, 2021-11-04).

This didn't matter for the GitHub CI, but does when running the check locally. A subsequent commit will start invoking it via a new check from the top-level Makefile, and without this we'd visibly spawn a pager when doing so.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 ci/check-directional-formatting.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ci/check-directional-formatting.bash b/ci/check-directional-formatting.bash
index e6211b141aa..de8e6e486f0 100755
--- a/ci/check-directional-formatting.bash
+++ b/ci/check-directional-formatting.bash
@@ -23,5 +23,5 @@
 # U+2066..U+2069: LRI, RLI, FSI and PDI
 regex='(\u202a|\u202b|\u202c|\u202d|\u202e|\u2066|\u2067|\u2068|\u2069)'
 
-! LC_CTYPE=C git grep -El "$(LC_CTYPE=C.UTF-8 printf "$regex")" \
+! LC_CTYPE=C git -P grep -El "$(LC_CTYPE=C.UTF-8 printf "$regex")" \
 	-- ':(exclude,attr:binary)' ':(exclude)*.po'
-- 
2.37.1.996.g651fc6e809f
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 9 of 11 in “ci: make it easy to run locally, part 1”
  1. 00/10 ci: make it easy to run locally, part 1Ævar Arnfjörð Bjarmason, Jul 14, 2022
  2. 01/10 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, Jul 14, 2022
  3. 02/10 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, Jul 14, 2022
  4. 03/10 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, Jul 14, 2022
  5. 04/10 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, Jul 14, 2022
  6. 05/10 CI/lib.sh: stop adding leading whitespace to $MAKEFLAGSÆvar Arnfjörð Bjarmason, Jul 14, 2022
  7. 06/10 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, Jul 14, 2022
  8. 07/10 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, Jul 14, 2022
  9. 08/10 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, Jul 14, 2022
  10. 10/10 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, Jul 14, 2022
  11. 09/10 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, Jul 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.